diff options
| author | Alex Chan <alexc@tailscale.com> | 2025-09-30 09:02:56 +0100 |
|---|---|---|
| committer | Alex Chan <alex@alexwlchan.net> | 2025-10-02 08:38:11 +0100 |
| commit | 7dfa26778e7ca36a34e7d50c0f80fb60f6f54540 (patch) | |
| tree | 06037d9374286234cc44b76228061ddc6c945e30 /util/execqueue/execqueue_test.go | |
| parent | cca70ddbfc2727a2f38d9d178b52efcca842a256 (diff) | |
| download | tailscale-7dfa26778e7ca36a34e7d50c0f80fb60f6f54540.tar.xz tailscale-7dfa26778e7ca36a34e7d50c0f80fb60f6f54540.zip | |
derp/derphttp: de-flake DERP HTTP clients tests with memnet and synctest
Using memnet and synctest removes flakiness caused by real networking
and subtle timing differences.
Additionally, remove the `t.Logf` call inside the server's shutdown
goroutine that was causing a false positive data race detection.
The race detector is flagging a double write during this `t.Logf` call.
This is a common pattern, noted in golang/go#40343 and elsehwere in
this file, where using `t.Logf` after a test has finished can interact
poorly with the test runner.
This is a long-standing issue which became more common after rewriting
this test to use memnet and synctest.
Fixed #17355
Signed-off-by: Alex Chan <alexc@tailscale.com>
Diffstat (limited to 'util/execqueue/execqueue_test.go')
0 files changed, 0 insertions, 0 deletions
