summaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
-rw-r--r--cmd/cloner/cloner_test.go49
-rw-r--r--cmd/cloner/clonerex/clonerex.go25
-rw-r--r--cmd/cloner/clonerex/clonerex_clone.go30
3 files changed, 102 insertions, 2 deletions
diff --git a/cmd/cloner/cloner_test.go b/cmd/cloner/cloner_test.go
index cf1063714..3556c14bc 100644
--- a/cmd/cloner/cloner_test.go
+++ b/cmd/cloner/cloner_test.go
@@ -59,3 +59,52 @@ func TestSliceContainer(t *testing.T) {
})
}
}
+
+func TestInterfaceContainer(t *testing.T) {
+ examples := []struct {
+ name string
+ in *clonerex.InterfaceContainer
+ }{
+ {
+ name: "nil",
+ in: nil,
+ },
+ {
+ name: "zero",
+ in: &clonerex.InterfaceContainer{},
+ },
+ {
+ name: "with_interface",
+ in: &clonerex.InterfaceContainer{
+ Interface: &clonerex.CloneableImpl{Value: 42},
+ },
+ },
+ {
+ name: "with_nil_interface",
+ in: &clonerex.InterfaceContainer{
+ Interface: nil,
+ },
+ },
+ }
+
+ for _, ex := range examples {
+ t.Run(ex.name, func(t *testing.T) {
+ out := ex.in.Clone()
+ if !reflect.DeepEqual(ex.in, out) {
+ t.Errorf("Clone() = %v, want %v", out, ex.in)
+ }
+
+ // Verify no aliasing: modifying the clone should not affect the original
+ if ex.in != nil && ex.in.Interface != nil {
+ if impl, ok := out.Interface.(*clonerex.CloneableImpl); ok {
+ impl.Value = 999
+ if origImpl, ok := ex.in.Interface.(*clonerex.CloneableImpl); ok {
+ if origImpl.Value == 999 {
+ t.Errorf("Clone() aliased memory with original")
+ }
+ }
+ }
+ }
+ })
+ }
+}
diff --git a/cmd/cloner/clonerex/clonerex.go b/cmd/cloner/clonerex/clonerex.go
index 96bf8a0bd..6463f9144 100644
--- a/cmd/cloner/clonerex/clonerex.go
+++ b/cmd/cloner/clonerex/clonerex.go
@@ -1,7 +1,7 @@
// Copyright (c) Tailscale Inc & AUTHORS
// SPDX-License-Identifier: BSD-3-Clause
-//go:generate go run tailscale.com/cmd/cloner -clonefunc=true -type SliceContainer
+//go:generate go run tailscale.com/cmd/cloner -clonefunc=true -type SliceContainer,InterfaceContainer
// Package clonerex is an example package for the cloner tool.
package clonerex
@@ -9,3 +9,26 @@ package clonerex
type SliceContainer struct {
Slice []*int
}
+
+// Cloneable is an interface with a Clone method.
+type Cloneable interface {
+ Clone() Cloneable
+}
+
+// CloneableImpl is a concrete type that implements Cloneable.
+type CloneableImpl struct {
+ Value int
+}
+
+func (c *CloneableImpl) Clone() Cloneable {
+ if c == nil {
+ return nil
+ }
+ return &CloneableImpl{Value: c.Value}
+}
+
+// InterfaceContainer has a pointer to an interface field, which tests
+// the special handling for interface types in the cloner.
+type InterfaceContainer struct {
+ Interface Cloneable
+}
diff --git a/cmd/cloner/clonerex/clonerex_clone.go b/cmd/cloner/clonerex/clonerex_clone.go
index e334a4e3a..533d7e723 100644
--- a/cmd/cloner/clonerex/clonerex_clone.go
+++ b/cmd/cloner/clonerex/clonerex_clone.go
@@ -35,9 +35,28 @@ var _SliceContainerCloneNeedsRegeneration = SliceContainer(struct {
Slice []*int
}{})
+// Clone makes a deep copy of InterfaceContainer.
+// The result aliases no memory with the original.
+func (src *InterfaceContainer) Clone() *InterfaceContainer {
+ if src == nil {
+ return nil
+ }
+ dst := new(InterfaceContainer)
+ *dst = *src
+ if src.Interface != nil {
+ dst.Interface = src.Interface.Clone()
+ }
+ return dst
+}
+
+// A compilation failure here means this code must be regenerated, with the command at the top of this file.
+var _InterfaceContainerCloneNeedsRegeneration = InterfaceContainer(struct {
+ Interface Cloneable
+}{})
+
// Clone duplicates src into dst and reports whether it succeeded.
// To succeed, <src, dst> must be of types <*T, *T> or <*T, **T>,
-// where T is one of SliceContainer.
+// where T is one of SliceContainer,InterfaceContainer.
func Clone(dst, src any) bool {
switch src := src.(type) {
case *SliceContainer:
@@ -49,6 +68,15 @@ func Clone(dst, src any) bool {
*dst = src.Clone()
return true
}
+ case *InterfaceContainer:
+ switch dst := dst.(type) {
+ case *InterfaceContainer:
+ *dst = *src.Clone()
+ return true
+ case **InterfaceContainer:
+ *dst = src.Clone()
+ return true
+ }
}
return false
}