From 41fd4eab5c13b12dbafc16a4496af63f20432d03 Mon Sep 17 00:00:00 2001 From: Brad Fitzpatrick Date: Mon, 24 Jan 2022 10:52:57 -0800 Subject: envknob: add new package for all the strconv.ParseBool(os.Getenv(..)) A new package can also later record/report which knobs are checked and set. It also makes the code cleaner & easier to grep for env knobs. Change-Id: Id8a123ab7539f1fadbd27e0cbeac79c2e4f09751 Signed-off-by: Brad Fitzpatrick --- control/controlknobs/controlknobs.go | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'control/controlknobs/controlknobs.go') diff --git a/control/controlknobs/controlknobs.go b/control/controlknobs/controlknobs.go index 84d71fdf2..5c3c3865c 100644 --- a/control/controlknobs/controlknobs.go +++ b/control/controlknobs/controlknobs.go @@ -7,9 +7,7 @@ package controlknobs import ( - "os" - "strconv" - + "tailscale.com/envknob" "tailscale.com/syncs" ) @@ -17,8 +15,7 @@ import ( var disableUPnP syncs.AtomicBool func init() { - v, _ := strconv.ParseBool(os.Getenv("TS_DISABLE_UPNP")) - SetDisableUPnP(v) + SetDisableUPnP(envknob.Bool("TS_DISABLE_UPNP")) } // DisableUPnP reports the last reported value from control -- cgit v1.3-3-g829e