From 8b47322acc2f3dabff40cbc4dcee9576f4d19bc5 Mon Sep 17 00:00:00 2001 From: Jordan Whited Date: Tue, 23 Jan 2024 09:37:32 -0800 Subject: wgengine/magicsock: implement probing of UDP path lifetime (#10844) This commit implements probing of UDP path lifetime on the tail end of an active direct connection. Probing configuration has two parts - Cliffs, which are various timeout cliffs of interest, and CycleCanStartEvery, which limits how often a probing cycle can start, per-endpoint. Initially a statically defined default configuration will be used. The default configuration has cliffs of 10s, 30s, and 60s, with a CycleCanStartEvery of 24h. Probing results are communicated via clientmetric counters. Probing is off by default, and can be enabled via control knob. Probing is purely informational and does not yet drive any magicsock behaviors. Updates #540 Signed-off-by: Jordan Whited --- control/controlknobs/controlknobs.go | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'control/controlknobs/controlknobs.go') diff --git a/control/controlknobs/controlknobs.go b/control/controlknobs/controlknobs.go index f9ed69812..6a36c9261 100644 --- a/control/controlknobs/controlknobs.go +++ b/control/controlknobs/controlknobs.go @@ -69,6 +69,10 @@ type Knobs struct { // renewing node keys without breaking connections. // http://go/seamless-key-renewal SeamlessKeyRenewal atomic.Bool + + // ProbeUDPLifetime is whether the node should probe UDP path lifetime on + // the tail end of an active direct connection in magicsock. + ProbeUDPLifetime atomic.Bool } // UpdateFromNodeAttributes updates k (if non-nil) based on the provided self @@ -95,6 +99,7 @@ func (k *Knobs) UpdateFromNodeAttributes(selfNodeAttrs []tailcfg.NodeCapability, forceIPTables = has(tailcfg.NodeAttrLinuxMustUseIPTables) forceNfTables = has(tailcfg.NodeAttrLinuxMustUseNfTables) seamlessKeyRenewal = has(tailcfg.NodeAttrSeamlessKeyRenewal) + probeUDPLifetime = has(tailcfg.NodeAttrProbeUDPLifetime) ) if has(tailcfg.NodeAttrOneCGNATEnable) { @@ -116,6 +121,7 @@ func (k *Knobs) UpdateFromNodeAttributes(selfNodeAttrs []tailcfg.NodeCapability, k.LinuxForceIPTables.Store(forceIPTables) k.LinuxForceNfTables.Store(forceNfTables) k.SeamlessKeyRenewal.Store(seamlessKeyRenewal) + k.ProbeUDPLifetime.Store(probeUDPLifetime) } // AsDebugJSON returns k as something that can be marshalled with json.Marshal @@ -138,5 +144,6 @@ func (k *Knobs) AsDebugJSON() map[string]any { "LinuxForceIPTables": k.LinuxForceIPTables.Load(), "LinuxForceNfTables": k.LinuxForceNfTables.Load(), "SeamlessKeyRenewal": k.SeamlessKeyRenewal.Load(), + "ProbeUDPLifetime": k.ProbeUDPLifetime.Load(), } } -- cgit v1.3-3-g829e