Do not set max_udp_payload_size in masquemasque-proxy-reduce-lock-contention

There is no point in setting max_udp_payload_size to limit the size
of packets we can receive, because because the relay will do path-MTU
detection anyway.

There is also no point in limiting the size of packets that we send,
to max_udp_payload_size, since quinn does path-MTU detection which
we must respect regardless.

We were basing the value of max_udp_payload_size on the link-MTU
(not path-MTU), and not accounting for whether that value should
change over the lifetime of the connection. The link-MTU is mostly
uninteresting, because it is always `>= 1500` unless the user has
changed it, which most people don't.

We do technically still set `max_udp_payload_size`, because the
server requires it, but we always set it to the default value of
`1500 - IP_HEADER`

1 files changed, 0 insertions, 1 deletions

diff --git a/mullvad-masque-proxy/tests/proxy.rs b/mullvad-masque-proxy/tests/proxy.rs
index b8681166c1..03da76f572 100644
--- a/mullvad-masque-proxy/tests/proxy.rs
+++ b/mullvad-masque-proxy/tests/proxy.rs
@@ -178,7 +178,6 @@ async fn setup_masque(mtu: u16) -> anyhow::Result<(UdpSocket, UdpSocket)> {
         .server_addr(masque_server_addr)
         .server_host(HOST.to_owned())
         .target_addr(target_udp_addr)
-        .mtu(mtu)
         .idle_timeout(Some(Duration::from_secs(10)))
         .auth_header(Some("Bearer test".to_owned()))
         .build();