1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
|
use std::future::Future;
use std::str::FromStr;
use std::sync::Arc;
use http::StatusCode;
use http::header;
use mullvad_update::version::{Rollout, VersionInfo, VersionParameters, is_version_supported};
type AppVersion = String;
use super::APP_URL_PREFIX;
use super::rest;
#[derive(Clone)]
pub struct AppVersionProxy {
handle: super::rest::MullvadRestHandle,
}
#[derive(Debug)]
pub struct AppVersionResponse {
response: AppVersionResponseRaw,
pub etag: Option<String>,
}
#[derive(serde::Deserialize, Debug)]
struct AppVersionResponseRaw {
supported: bool,
latest: AppVersion,
latest_stable: Option<AppVersion>,
latest_beta: Option<AppVersion>,
}
impl AppVersionResponse {
pub const fn supported(&self) -> bool {
self.response.supported
}
pub const fn latest_stable(&self) -> Option<&AppVersion> {
self.response.latest_stable.as_ref()
}
pub const fn latest_beta(&self) -> Option<&AppVersion> {
self.response.latest_beta.as_ref()
}
}
/// Reply from `/app/releases/<platform>.json` endpoint
pub struct AppVersionResponse2 {
/// Information about available versions for the current target
pub version_info: VersionInfo,
/// Index of the metadata version used to sign the response.
/// Used to prevent replay/downgrade attacks.
pub metadata_version: usize,
/// Whether or not the current app version (mullvad_version::VERSION) is supported.
pub current_version_supported: bool,
/// ETag for the response
pub etag: Option<String>,
}
impl AppVersionProxy {
/// Maximum size of `version_check_2` response
const SIZE_LIMIT: usize = 1024 * 1024;
pub fn new(handle: rest::MullvadRestHandle) -> Self {
Self { handle }
}
pub fn version_check(
&self,
app_version: AppVersion,
platform: &str,
platform_version: Option<String>,
etag: Option<String>,
) -> impl Future<Output = Result<Option<AppVersionResponse>, rest::Error>> + use<> {
let service = self.handle.service.clone();
let path = format!("{APP_URL_PREFIX}/releases/{platform}/{app_version}");
let request = self.handle.factory.get(&path);
async move {
let mut request = request?.expected_status(&[StatusCode::NOT_MODIFIED, StatusCode::OK]);
if let Some(platform_version) = platform_version {
request = request.header("M-Platform-Version", &platform_version)?;
}
if let Some(ref tag) = etag {
request = request.header(header::IF_NONE_MATCH, tag)?;
}
let response = service.request(request).await?;
if etag.is_some() && response.status() == StatusCode::NOT_MODIFIED {
return Ok(None);
}
let etag = Self::extract_etag(&response);
let deserialized: AppVersionResponseRaw = response.deserialize().await?;
let _ = deserialized.latest; // we do not use this
Ok(Some(AppVersionResponse {
response: deserialized,
etag,
}))
}
}
/// Get versions from `/app/releases/<platform>.json`
///
/// This returns `None` if the server responds with 304 (version is same as etag).
pub fn version_check_2(
&self,
platform: &str,
architecture: mullvad_update::format::Architecture,
lowest_metadata_version: usize,
platform_version: Option<String>,
rollout: Rollout,
etag: Option<String>,
) -> impl Future<Output = Result<Option<AppVersionResponse2>, rest::Error>> + use<> {
let service = self.handle.service.clone();
let path = format!("app/releases/{platform}.json");
let request = self.handle.factory.get(&path);
async move {
let mut request = request?.expected_status(&[StatusCode::NOT_MODIFIED, StatusCode::OK]);
if let Some(platform_version) = platform_version {
request = request
.header(
"M-App-Version",
&sanitize_header_value(mullvad_version::VERSION),
)?
.header(
"M-Platform-Version",
&sanitize_header_value(&platform_version),
)?;
}
if let Some(ref tag) = etag {
request = request.header(header::IF_NONE_MATCH, tag)?;
}
let response = service.request(request).await?;
if etag.is_some() && response.status() == StatusCode::NOT_MODIFIED {
return Ok(None);
}
let etag = Self::extract_etag(&response);
let bytes = response.body_with_max_size(Self::SIZE_LIMIT).await?;
let response = mullvad_update::format::SignedResponse::deserialize_and_verify(
&bytes,
lowest_metadata_version,
)
.map_err(|err| rest::Error::FetchVersions(Arc::new(err)))?;
let params = VersionParameters {
architecture,
rollout,
// NOTE: On Linux, version metadata contains no installers
allow_empty: cfg!(target_os = "linux"),
lowest_metadata_version,
};
let current_version =
mullvad_version::Version::from_str(mullvad_version::VERSION).unwrap();
let current_version_supported = is_version_supported(current_version, &response.signed);
let metadata_version = response.signed.metadata_version;
Ok(Some(AppVersionResponse2 {
version_info: VersionInfo::try_from_response(¶ms, response.signed)
.map_err(Arc::new)
.map_err(rest::Error::FetchVersions)?,
metadata_version,
current_version_supported,
etag,
}))
}
}
pub fn extract_etag(response: &rest::Response<hyper::body::Incoming>) -> Option<String> {
response
.headers()
.get(header::ETAG)
.and_then(|tag| match tag.to_str() {
Ok(tag) => Some(tag.to_string()),
Err(_) => {
log::error!("Ignoring invalid tag from server: {:?}", tag.as_bytes());
None
}
})
}
}
// This function makes a string conform to the allowed characters and length of header values.
// Here's the rule it needs to implement: [A-Za-z0-9_.-]{1,64}
fn sanitize_header_value(value: &str) -> String {
value
.chars()
.map(|c| if c.is_whitespace() { '_' } else { c })
.filter(|&c| c.is_ascii_alphanumeric() || "_.-".contains(c))
.take(64)
.collect()
}
#[cfg(test)]
mod test {
use super::*;
#[test]
fn test_sanitize_header_value() {
assert_eq!(sanitize_header_value("2025.5"), "2025.5");
assert_eq!(sanitize_header_value("Fedora Linux"), "Fedora_Linux");
assert_eq!(sanitize_header_value("macOS 26.1"), "macOS_26.1");
assert_eq!(sanitize_header_value("Déjà vu OS"), "Dj_vu_OS");
let long_value =
"abcdefghijklmnopqrstuvxyzabcdefghijklmnopqrstuvxyzabcdefghijklmnopqrstuvxyz";
let mut truncated_long_value = long_value.to_owned();
truncated_long_value.truncate(64);
assert_eq!(sanitize_header_value(long_value), truncated_long_value);
}
}
|
