1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
|
// pathedit.cpp : Defines the exported functions for the DLL application.
//
#include "stdafx.h"
#include "../error.h"
#include <windows.h>
#include <libcommon/string.h>
#include <libcommon/registry/registry.h>
#include <libcommon/registry/registrypath.h>
#include <libcommon/registry/registrykey.h>
#include <libcommon/error.h>
#include <nsis/pluginapi.h>
#include <string>
// Suppress warnings caused by broken legacy code
#pragma warning (push)
#pragma warning (disable: 4005)
#include <nsis/pluginapi.h>
#pragma warning (pop)
using namespace common::registry;
using ValueStringType = RegistryKey::ValueStringType;
using common::string::Lower;
static constexpr wchar_t pathKeyName[] = L"SYSTEM\\CurrentControlSet\\Control\\Session Manager\\Environment";
static constexpr wchar_t pathValName[] = L"Path";
static constexpr size_t messageTimeoutInterval = 5;
namespace
{
std::wstring PopString()
{
//
// NSIS functions popstring() and popstringn() require that you definitely size the buffer
// before popping the string. Let's do it ourselves instead.
//
if (!g_stacktop || !*g_stacktop)
{
THROW_ERROR("NSIS variable stack is corrupted");
}
stack_t *th = *g_stacktop;
std::wstring copy(th->text);
*g_stacktop = th->next;
GlobalFree((HGLOBAL)th);
return copy;
}
std::vector<std::wstring>::const_iterator FindSysPath(const std::vector<std::wstring> &pathTokens, const std::wstring &path)
{
const std::wstring lowerPath = Lower(path);
return std::find_if(
pathTokens.begin(),
pathTokens.end(),
[&lowerPath](const std::wstring &elem)
{
return Lower(elem).compare(lowerPath) == 0;
}
);
}
bool SysPathExists(const std::wstring &allPaths, const std::wstring &pathToFind)
{
auto pathTokens = common::string::Tokenize(allPaths, L";");
return FindSysPath(pathTokens, pathToFind) != pathTokens.end();
}
std::wstring ReadPathValue(const RegistryKey &pathKey)
{
// Some applications will replace the PATH value with a regular string;
// use this type as a fallback.
try
{
return pathKey.readString(pathValName, ValueStringType::ExpandableString);
}
catch (const std::exception &)
{
return pathKey.readString(pathValName, ValueStringType::RegularString);
}
}
} // anonymous namespace
//
// AddSysEnvPath "path"
//
// Adds "path" to the system PATH environment variable,
// or does nothing if it already exists.
//
// Example usage:
//
// AddSysEnvPath "C:\path\to\directory"
//
void __declspec(dllexport) NSISCALL AddSysEnvPath
(
HWND hwndParent,
int string_size,
LPTSTR variables,
stack_t **stacktop,
extra_parameters *extra,
...
)
{
EXDLL_INIT();
try
{
{
const auto pathToAppend = PopString();
auto pathRegKey = Registry::OpenKey(
HKEY_LOCAL_MACHINE,
pathKeyName,
true,
RegistryView::Force64
);
std::wstring path = ReadPathValue(*pathRegKey);
if (SysPathExists(path, pathToAppend))
{
pushstring(L"");
pushint(NsisStatus::SUCCESS);
return;
}
if (!path.empty())
{
path.append(L";");
}
path.append(pathToAppend);
pathRegKey->writeValue(pathValName, path, ValueStringType::ExpandableString);
pathRegKey->flush();
}
DWORD result;
auto status = SendMessageTimeoutA(HWND_BROADCAST, WM_SETTINGCHANGE, 0,
(LPARAM)"Environment", SMTO_ABORTIFHUNG, messageTimeoutInterval, &result);
if (0 == status)
{
THROW_WINDOWS_ERROR(GetLastError(), "SendMessageTimeoutA");
}
status = SendMessageTimeoutW(HWND_BROADCAST, WM_SETTINGCHANGE, 0,
(LPARAM)L"Environment", SMTO_ABORTIFHUNG, messageTimeoutInterval, &result);
if (0 == status)
{
THROW_WINDOWS_ERROR(GetLastError(), "SendMessageTimeoutW");
}
pushstring(L"");
pushint(NsisStatus::SUCCESS);
}
catch (const std::exception &err)
{
pushstring(common::string::ToWide(err.what()).c_str());
pushint(NsisStatus::GENERAL_ERROR);
}
catch (...)
{
pushstring(L"Unspecified error");
pushint(NsisStatus::GENERAL_ERROR);
}
}
//
// RemoveSysEnvPath "path"
//
// Removes "path" to the system PATH environment variable,
// or does nothing if it doesn't exist.
//
// Example usage:
//
// RemoveSysEnvPath "C:\path\to\directory"
//
void __declspec(dllexport) NSISCALL RemoveSysEnvPath
(
HWND hwndParent,
int string_size,
LPTSTR variables,
stack_t **stacktop,
extra_parameters *extra,
...
)
{
EXDLL_INIT();
try
{
const auto pathToRemove = PopString();
bool updatedPath = false;
{
auto pathRegKey = Registry::OpenKey(
HKEY_LOCAL_MACHINE,
pathKeyName,
true,
RegistryView::Force64
);
std::wstring path = ReadPathValue(*pathRegKey);
// remove value if it exists in PATH
auto pathTokens = common::string::Tokenize(path, L";");
auto match = FindSysPath(pathTokens, pathToRemove);
if (match != pathTokens.end())
{
pathTokens.erase(match);
path = common::string::Join(pathTokens, L";");
pathRegKey->writeValue(pathValName, path, ValueStringType::ExpandableString);
updatedPath = true;
}
}
if (updatedPath)
{
DWORD result;
auto status = SendMessageTimeoutA(HWND_BROADCAST, WM_SETTINGCHANGE, 0,
(LPARAM)"Environment", SMTO_ABORTIFHUNG, messageTimeoutInterval, &result);
if (0 == status)
{
THROW_WINDOWS_ERROR(GetLastError(), "SendMessageTimeoutA");
}
status = SendMessageTimeoutW(HWND_BROADCAST, WM_SETTINGCHANGE, 0,
(LPARAM)L"Environment", SMTO_ABORTIFHUNG, messageTimeoutInterval, &result);
if (0 == status)
{
THROW_WINDOWS_ERROR(GetLastError(), "SendMessageTimeoutW");
}
}
pushstring(L"");
pushint(NsisStatus::SUCCESS);
}
catch (const std::exception &err)
{
pushstring(common::string::ToWide(err.what()).c_str());
pushint(NsisStatus::GENERAL_ERROR);
}
catch (...)
{
pushstring(L"Unspecified error");
pushint(NsisStatus::GENERAL_ERROR);
}
}
|
