fix(channel): stack-buffer-overflow with exit during connection (#39387)release-0.12

Problem:  When Nvim exits while connecting to a socket it leads to
          stack-buffer-overflow.
Solution: Associate the handle with the Stream and use the Stream's
          internal_close_cb to update the "closed" status.
(cherry picked from commit 4ed2e66d2ec20c2bf0325283b0e785ca3abb15c0)

1 files changed, 2 insertions, 2 deletions

diff --git a/src/nvim/event/stream.c b/src/nvim/event/stream.c
index 24bf8b5fe4..be3120a196 100644
--- a/src/nvim/event/stream.c
+++ b/src/nvim/event/stream.c
@@ -143,8 +143,8 @@ void stream_close_handle(Stream *stream)
 static void close_cb(uv_handle_t *handle)
 {
   Stream *stream = handle->data;
-  // Need to check if handle->data is NULL here as this callback may be called between
-  // the handle's initialization and stream_init() (e.g. in socket_connect()).
+  // Check if handle->data is NULL here, in case this callback is called between
+  // the handle's initialization and stream_init().
   if (stream && stream->close_cb) {
     stream->close_cb(stream, stream->close_cb_data);
   }